-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TermsOfUse): Add Terms of Use modal #349
Conversation
Preview: https://chatbot-pr-chatbot-349.surge.sh A11y report: https://chatbot-pr-chatbot-349-a11y.surge.sh |
e8ffbe9
to
4df4b03
Compare
7c0bbb5
to
00404c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/TermsOfUse.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things!
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/TermsOfUse.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/TermsOfUse.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/TermsOfUse.tsx
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/chatbot/examples/UI/TermsOfUse.tsx
Outdated
Show resolved
Hide resolved
Changes are all set! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖✍️
</h1> | ||
</div> | ||
</ModalHeader> | ||
<ModalBody id="terms-of-use-modal-body"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of hardcoded ids in this file which should not be hardcoded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set!
…mples/UI/TermsOfUse.tsx Co-authored-by: Erin Donehoo <[email protected]>
…mples/UI/UI.md Co-authored-by: Erin Donehoo <[email protected]>
…mples/UI/TermsOfUse.tsx Co-authored-by: Erin Donehoo <[email protected]>
…mples/UI/TermsOfUse.tsx Co-authored-by: Erin Donehoo <[email protected]>
…mples/UI/TermsOfUse.tsx Co-authored-by: Erin Donehoo <[email protected]>
🎉 This PR is included in version 2.2.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Docs: https://chatbot-pr-chatbot-349.surge.sh/patternfly-ai/chatbot/ui/#terms-of-use
Example: https://chatbot-pr-chatbot-349.surge.sh/patternfly-ai/chatbot/ui/react/terms-of-use/