Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TermsOfUse): Add Terms of Use modal #349

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

@patternfly-build
Copy link

patternfly-build commented Dec 3, 2024

@rebeccaalpert rebeccaalpert force-pushed the terms branch 3 times, most recently from e8ffbe9 to 4df4b03 Compare December 3, 2024 17:25
@rebeccaalpert rebeccaalpert linked an issue Dec 3, 2024 that may be closed by this pull request
@rebeccaalpert rebeccaalpert force-pushed the terms branch 4 times, most recently from 7c0bbb5 to 00404c8 Compare December 3, 2024 18:37
Copy link

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few things!

@rebeccaalpert
Copy link
Member Author

Changes are all set!

@rebeccaalpert rebeccaalpert changed the title Draft: feat(TermsOfUse): Add Terms of Use modal feat(TermsOfUse): Add Terms of Use modal Dec 9, 2024
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖✍️

</h1>
</div>
</ModalHeader>
<ModalBody id="terms-of-use-modal-body">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of hardcoded ids in this file which should not be hardcoded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

@nicolethoen nicolethoen merged commit 3b45d76 into patternfly:main Dec 17, 2024
5 checks passed
Copy link

🎉 This PR is included in version 2.2.0-prerelease.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TermsOfUse component
5 participants